showuon commented on PR #15908: URL: https://github.com/apache/kafka/pull/15908#issuecomment-2123948788
One high-level question: I found after this change, we increased the test case numbers from 492 -> 660. And the time for this test suite takes form 1h 19m -> 1h 31m. Do we really need all these tests? Could we try to: 1. at least maintain the same test case numbers as before? 2. (could be in another PR) Try to speed up the test. Maybe disable `log.cleaner.enable`, deploy for 1 nodes if we are not testing the data replication... etc? Anyway, to me, one test class takes more than 1 hour is really unacceptable. Trunk: https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/2924/testReport/org.apache.kafka.tools.consumer.group/ This PR: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15908/1/testReport/org.apache.kafka.tools.consumer.group/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
