apoorvmittal10 commented on code in PR #16022: URL: https://github.com/apache/kafka/pull/16022#discussion_r1609651226
########## clients/src/main/java/org/apache/kafka/common/errors/FencedStateEpochException.java: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.errors; + +public class FencedStateEpochException extends ApiException { Review Comment: Can we please have the comments for the exception class as like `InvalidRecordStateException` class defined in the PR. Sorry for missing this earlier but seems this error class is not defined in the KIP though others are. ########## clients/src/main/java/org/apache/kafka/common/requests/ShareGroupDescribeRequest.java: ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.requests; + +import org.apache.kafka.common.message.ShareGroupDescribeRequestData; +import org.apache.kafka.common.message.ShareGroupDescribeResponseData; +import org.apache.kafka.common.protocol.ApiKeys; +import org.apache.kafka.common.protocol.ByteBufferAccessor; +import org.apache.kafka.common.protocol.Errors; + +import java.nio.ByteBuffer; +import java.util.List; +import java.util.stream.Collectors; + +public class ShareGroupDescribeRequest extends AbstractRequest { + + public static class Builder extends AbstractRequest.Builder<ShareGroupDescribeRequest> { + + private final ShareGroupDescribeRequestData data; + + public Builder(ShareGroupDescribeRequestData data) { + this(data, false); + } + + public Builder(ShareGroupDescribeRequestData data, boolean enableUnstableLastVersion) { + super(ApiKeys.SHARE_GROUP_DESCRIBE, enableUnstableLastVersion); + this.data = data; + } + + @Override + public ShareGroupDescribeRequest build(short version) { + return new ShareGroupDescribeRequest(data, version); + } + + @Override + public String toString() { + return data.toString(); + } + } + + private final ShareGroupDescribeRequestData data; + + public ShareGroupDescribeRequest(ShareGroupDescribeRequestData data, short version) { + super(ApiKeys.SHARE_GROUP_DESCRIBE, version); + this.data = data; + } + + @Override + public ShareGroupDescribeResponse getErrorResponse(int throttleTimeMs, Throwable e) { + ShareGroupDescribeResponseData data = new ShareGroupDescribeResponseData() + .setThrottleTimeMs(throttleTimeMs); + // Set error for each group + short errorCode = Errors.forException(e).code(); + this.data.groupIds().forEach( + groupId -> data.groups().add( + new ShareGroupDescribeResponseData.DescribedGroup() + .setGroupId(groupId) + .setErrorCode(errorCode) + ) + ); + return new ShareGroupDescribeResponse(data); + } + + @Override + public ShareGroupDescribeRequestData data() { + return data; + } + + public static ShareGroupDescribeRequest parse(ByteBuffer buffer, short version) { + return new ShareGroupDescribeRequest( + new ShareGroupDescribeRequestData(new ByteBufferAccessor(buffer), version), + version + ); + } + + public static List<ShareGroupDescribeResponseData.DescribedGroup> getErrorDescribedGroupList( Review Comment: Generally I have received feedback of not including `get` in such getters so may be rename method to `errorDescribedGroupList`. ########## clients/src/main/resources/common/message/FindCoordinatorRequest.json: ########## @@ -27,7 +27,9 @@ // Version 4 adds support for batching via CoordinatorKeys (KIP-699) // // Version 5 adds support for new error code TRANSACTION_ABORTABLE (KIP-890). - "validVersions": "0-5", + // + // Version 6 adds support for share groups (KIP-932). Review Comment: We might want to update KIP with version 6 as KIP says version 5 is added for KIP-932. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
