dajac commented on code in PR #15685: URL: https://github.com/apache/kafka/pull/15685#discussion_r1609917313
########## server-common/src/main/java/org/apache/kafka/server/common/FeatureVersion.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.server.common; + +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +public interface FeatureVersion { + + /** + * The level of the feature. 0 means the feature is disabled. + */ + short featureLevel(); + + /** + * The name of the feature. + */ + String featureName(); + + /** + * The next metadata version to be released when the feature became production ready. + * (Ie, if the current production MV is 17 when a feature is released, its mapping should be to MV 18) + */ + MetadataVersion metadataVersionMapping(); Review Comment: > I would like the mapping to remain consistent for MV. If we do the current mapping, some versions/images with MV X will have feature version Y and some will not (since it wasn't created when MV X was first released) Isn't it something that will happen anyway? For instance, I will add `group.version=1` soon and it will require an old MV. Likely the oldest one supported by kraft. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
