muralibasani commented on PR #16005: URL: https://github.com/apache/kafka/pull/16005#issuecomment-2127157602
@nikramakrishnan somehow am not feeling confident to write a test based on the order of execution. Instead we should throw an exception (or stateChangeLogger.error) like mentioned below here, and write a unit test just for this class. With this approach, whenever there are metadata changes, and remote log storage is enabled. wdyt ? > @clolov In ReplicaManager.scala, if REMOTE_LOG_STORAGE_SYSTEM_ENABLE_PROP is enabled and if remoteLogManager is None do we want to throw any exception before the below line remoteLogManager.foreach(rlm => rlm.onLeadershipChange(l.... > > then we can add a test easily -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
