m1a2st commented on code in PR #16042:
URL: https://github.com/apache/kafka/pull/16042#discussion_r1613531701
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -6594,6 +6594,64 @@ class ReplicaManagerTest {
))
}
}
+
+ @Test
+ def testReplicaManagerDontGenerateEmptyTopicPartition(): Unit = {
Review Comment:
Because there is a test that direct to test `describeLogDirs` method in
ReplicaManagerTest, So I consider that to wirte a new test in
`ReplicaManagerTest` is better than `DescribeLogDirsRequestTest`
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -6594,6 +6594,64 @@ class ReplicaManagerTest {
))
}
}
+
+ @Test
+ def testReplicaManagerDontGenerateEmptyTopicPartition(): Unit = {
Review Comment:
Because there is a test that direct to test `describeLogDirs` method in
ReplicaManagerTest, So I consider that to wirte a new test in
`ReplicaManagerTest` is better than `DescribeLogDirsRequestTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
