brandboat commented on code in PR #16085:
URL: https://github.com/apache/kafka/pull/16085#discussion_r1616260244
##########
core/src/test/scala/unit/kafka/log/LogSegmentsTest.scala:
##########
@@ -105,8 +109,6 @@ class LogSegmentsTest {
assertFalse(segments.nonEmpty)
assertEquals(0, segments.numberOfSegments)
assertFalse(segments.contains(offset1))
-
- segments.close()
Review Comment:
Invoking `segments.close()` is redundant here since `segments.clear()`
already empties the values in segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
