dajac commented on code in PR #16057:
URL: https://github.com/apache/kafka/pull/16057#discussion_r1617618237
##########
checkstyle/suppressions.xml:
##########
@@ -347,7 +347,7 @@
<suppress checks="ClassDataAbstractionCouplingCheck"
files="(RecordHelpersTest|GroupMetadataManager|GroupMetadataManagerTest|OffsetMetadataManagerTest|GroupCoordinatorServiceTest|GroupCoordinatorShardTest).java"/>
<suppress checks="JavaNCSS"
- files="GroupMetadataManagerTest.java"/>
+ files="(GroupMetadataManager|GroupMetadataManagerTest).java"/>
Review Comment:
Do we still need this exception?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##########
@@ -1076,6 +1076,29 @@ public Map<String, Integer> computeSubscribedTopicNames(
return subscribedTopicNames;
}
+ /**
+ * Updates the subscription count with a set of members removed.
+ *
+ * @param removedMembers The set of removed members.
+ *
+ * @return Copy of the map of topics to the count of number of subscribers.
+ */
+ public Map<String, Integer> computeSubscribedTopicNames(
Review Comment:
nit: Should we add a unit test for this new method in ConsumerGroupTest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
