philipnee commented on code in PR #15961: URL: https://github.com/apache/kafka/pull/15961#discussion_r1618032800
########## clients/src/main/java/org/apache/kafka/clients/ClientUtils.java: ########## @@ -172,7 +173,37 @@ public static NetworkClient createNetworkClient(AbstractConfig config, null, new DefaultHostResolver(), throttleTimeSensor, - clientTelemetrySender); + clientTelemetrySender, + Function.identity()); Review Comment: i think we are going pretty deep to access the metadata error, i wonder if we could simplify the pattern. we can probably directly access the metadata error in the background thread and send it to the client, in this case we don't need to create a separated wrapper around the updater. wdyt if we just create a metadata error manager in the consumer network thread level and poll the metadata error directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org