dajac commented on code in PR #16120:
URL: https://github.com/apache/kafka/pull/16120#discussion_r1619171189
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3797,10 +3797,16 @@ class KafkaApis(val requestChannel: RequestChannel,
)
}
+ private def isConsumerGroupProtocolEnabled(): Boolean = {
+ val featureLevel =
metadataCache.features().finalizedFeatures().getOrDefault(GroupVersion.FEATURE_NAME,
GroupVersion.GV_1.featureLevel)
Review Comment:
Right. I thought that we could use version 1 as the default version for all
the existing APIs (old protocol, etc). If not provided, we can still default to
it.
I think that in the KIP, we said that we wanted to use version 0 for this
but as 0 also means disabled I found it weird. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
