chia7712 commented on code in PR #16121:
URL: https://github.com/apache/kafka/pull/16121#discussion_r1619227303
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -934,8 +934,11 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
throw new ConfigException(s"Disabling the '${GroupType.CLASSIC}'
protocol is not supported.")
}
if (protocols.contains(GroupType.CONSUMER)) {
Review Comment:
> except in some tests. I can still strengthen the validation of it too if
you want.
We don't need extra validation as it is used by testing only. BTW, will that
internal config be removed in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
