AndrewJSchofield commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1620630034
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##########
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Kafka auto-manage group
membership. If the consumer directly assigns partitions,
* those partitions will never be reassigned and this callback is not
applicable.
* <p>
- * When Kafka is managing the group membership, a partition re-assignment will
be triggered any time the members of the group change or the subscription
+ * When Kafka is managing the group membership, a partition re-assignment will
be triggered whenever the members of the group change or the subscription
* of the members changes. This can occur when processes die, new process
instances are added or old instances come back to life after failure.
- * Partition re-assignments can also be triggered by changes affecting the
subscribed topics (e.g. when the number of partitions is
+ * Partition re-assignments can also be triggered by changing affecting the
subscribed topics (e.g. when the number of partitions is
Review Comment:
"changing affecting" is not grammatical. I suggest reverting to "changes
affecting the subscribed topics".
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##########
@@ -144,8 +144,9 @@ public interface ConsumerRebalanceListener {
void onPartitionsRevoked(Collection<TopicPartition> partitions);
/**
- * A callback method the user can implement to provide handling of
customized offsets on completion of a successful
- * partition re-assignment. This method will be called after the partition
re-assignment completes and before the
+ * A callback method the user is providing handling of cleanup up resource
which are being assigned to other customers and
Review Comment:
This one isn't right. It's not usually used for cleanup and "customers" is
not right. I suggest "A callback method the user can implement to be notified
when partitions are assigned to this consumer. This method will be called after
the partition re-assignment completes and before....."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
