cadonna commented on code in PR #16093:
URL: https://github.com/apache/kafka/pull/16093#discussion_r1620709873
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java:
##########
@@ -288,7 +301,31 @@ private <K, V> void forwardInternal(final ProcessorNode<K,
V, ?, ?> child,
final Record<K, V> record) {
setCurrentNode(child);
- child.process(record);
+ try {
Review Comment:
@loicgreffier I came up with one option how to add the processing exception
handler to the processor node in the following draft PR:
https://github.com/apache/kafka/pull/16137
This will create a exception handler per task. BTW, the KIP does not say
anything about how many instances of the exception handler are created. Is it
one per processor, one per task, one per thread, or even one per Streams
client? The last one would require a thread-safe implementation of the handler.
A user needs to know the granularity of the exception handler when implementing
a handler that maintains state, e.g., counting the exceptions. I am in favor of
a handler instance per task.
Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
