satishd commented on code in PR #16132:
URL: https://github.com/apache/kafka/pull/16132#discussion_r1623787269
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -179,6 +182,7 @@ public Optional<String> serverConfigName(String configName)
{
public static final boolean DEFAULT_REMOTE_STORAGE_ENABLE = false;
public static final long DEFAULT_LOCAL_RETENTION_BYTES = -2; // It
indicates the value to be derived from RetentionBytes
public static final long DEFAULT_LOCAL_RETENTION_MS = -2; // It indicates
the value to be derived from RetentionMs
+ public static final String DEFAULT_REMOTE_LOG_DISABLE_POLICY = "retain";
Review Comment:
Can you declare the respective fields for valid values like "retain" and
"delete"?
##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -93,6 +93,11 @@ public class TopicConfig {
"deletes the old segments. Default value is -2, it represents
`retention.bytes` value to be used. The effective value should always be " +
"less than or equal to `retention.bytes` value.";
+ public static final String REMOTE_LOG_DISABLE_POLICY_CONFIG =
"remote.log.disable.policy";
+
+ public static final String REMOTE_LOG_DISABLE_POLICY_DOC = "Determines
whether tiered data for a topic should be retained or " +
Review Comment:
Can you add a note about the valid values in the doc and briefly talk about
the respective behavior of both values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
