showuon commented on code in PR #16105: URL: https://github.com/apache/kafka/pull/16105#discussion_r1624333042
########## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ########## @@ -383,8 +383,7 @@ class GroupMetadataManager(brokerId: Int, filteredOffsetMetadata: Map[TopicIdPartition, OffsetAndMetadata], responseCallback: immutable.Map[TopicIdPartition, Errors] => Unit, producerId: Long, Review Comment: nit: These parameters are not aligned with the 1st line. ``` private def createPutCacheCallback(isTxnOffsetCommit: Boolean, group: GroupMetadata, ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org