lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1624549518
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java:
##########
@@ -210,7 +194,7 @@ private NetworkClientDelegate.UnsentRequest
createUnsentRequest(
private void handleError(final Throwable exception,
final long completionTimeMs) {
if (exception instanceof RetriableException) {
- if (completionTimeMs >= expirationTimeMs) {
+ if (isExpired()) {
Review Comment:
this logic of what we want to do on retriable errors seems to be the same
for all retriable errors (no matter if found in `handleError` or
`handleResponse`). Could we maybe consolidate it in a single place
`maybeExpireOnRetriable` or something like it, that would be consistently
applied whenever we need to maybe expire?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
