philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1624598671
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -123,6 +123,46 @@ public void setup() {
this.props.put(VALUE_DESERIALIZER_CLASS_CONFIG,
StringDeserializer.class);
}
+ @Test
+ public void testOffsetFetchRequestStateToStringBase() {
+ ConsumerConfig config = mock(ConsumerConfig.class);
+ CommitRequestManager.MemberInfo memberInfo = new
CommitRequestManager.MemberInfo();
+
+ CommitRequestManager commitRequestManager = new CommitRequestManager(
+ time,
+ logContext,
+ subscriptionState,
+ config,
+ coordinatorRequestManager,
+ offsetCommitCallbackInvoker,
+ "groupId",
+ Optional.of("groupInstanceId"),
+ metrics);
+
+ CommitRequestManager.OffsetFetchRequestState offsetFetchRequestState =
commitRequestManager.new OffsetFetchRequestState(
+ new HashSet<>(),
+ retryBackoffMs,
+ retryBackoffMaxMs,
+ 1000,
+ memberInfo
+ );
+
+ RequestState requestState = new RequestState(
+ logContext,
+ "CommitRequestManager",
+ retryBackoffMs,
+ retryBackoffMaxMs);
+
+ String target = requestState.toStringBase() +
+ ", memberInfo=" + offsetFetchRequestState.memberInfo +
+ ", expirationTimeMs=" +
(offsetFetchRequestState.expirationTimeMs().isPresent() ?
offsetFetchRequestState.expirationTimeMs() : "undefined") +
+ ", isExpired=" + offsetFetchRequestState.isExpired +
+ ", requestedPartitions=" +
offsetFetchRequestState.requestedPartitions +
+ ", future=" + offsetFetchRequestState.future();
+
Review Comment:
can we also assert no exception can be thrown for calling toString() - just
to ensure no lousy toString().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
