jsancio commented on code in PR #15986: URL: https://github.com/apache/kafka/pull/15986#discussion_r1624697438
########## core/src/main/scala/kafka/server/SharedServer.scala: ########## @@ -94,6 +95,7 @@ class SharedServer( val time: Time, private val _metrics: Metrics, val controllerQuorumVotersFuture: CompletableFuture[JMap[Integer, InetSocketAddress]], + val bootstrapServers: JCollection[InetSocketAddress], Review Comment: It's the same reason why the `controllerQuorumVotersFuture` is passed as an argument and it is not read from the `KafkaConfig`. Tests tend to configure the voters using the `0` port so that the OS can dynamically assign an open port. We need the same functionality for `bootstrapServers` in most tests the bootstrap server are the same se of endpoint as the voters but without the node id. Having said that I have plans to remove all of these complexity after 3.8. This is mainly here before of kafka raft cluster test kit. I created this issue to track this work: https://issues.apache.org/jira/browse/KAFKA-16653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
