gharris1727 commented on code in PR #16151:
URL: https://github.com/apache/kafka/pull/16151#discussion_r1624740901
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -4569,7 +4569,7 @@ public ListTransactionsResult
listTransactions(ListTransactionsOptions options)
public FenceProducersResult fenceProducers(Collection<String>
transactionalIds, FenceProducersOptions options) {
AdminApiFuture.SimpleAdminApiFuture<CoordinatorKey,
ProducerIdAndEpoch> future =
FenceProducersHandler.newFuture(transactionalIds);
- FenceProducersHandler handler = new FenceProducersHandler(logContext);
+ FenceProducersHandler handler = new FenceProducersHandler(logContext,
requestTimeoutMs);
Review Comment:
If the AdminClient is no longer waiting for the fence request to complete,
does it make sense for the underlying append to continue?
If the AdminClient is willing to wait longer for the fence request to
complete, should the underlying append be aborted early?
If someone wants to raise the timeout for this one operation, I don't think
that we should require them to increase the client-global request.timeout.ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
