m1a2st commented on code in PR #16179:
URL: https://github.com/apache/kafka/pull/16179#discussion_r1625217653
##########
clients/src/main/java/org/apache/kafka/common/utils/SystemTime.java:
##########
@@ -26,6 +26,18 @@
*/
public class SystemTime implements Time {
+ /**
+ * use the static inner class to implement the singleton pattern
+ * to avoid the overhead of synchronization
Review Comment:
True, `SystemTime` is very cheap, but I think that don't use double-checked
locking to implement the singleton pattern, maybe I should remove this comment
is more better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
