muralibasani commented on code in PR #16168:
URL: https://github.com/apache/kafka/pull/16168#discussion_r1625901031


##########
core/src/test/scala/integration/kafka/network/DynamicConnectionQuotaTest.scala:
##########
@@ -275,7 +276,7 @@ class DynamicConnectionQuotaTest extends BaseRequestTest {
     val initialConnectionCount = connectionCount
     val entity = new ClientQuotaEntity(Map(ClientQuotaEntity.IP -> 
ip.orNull).asJava)
     val request = Map(entity -> 
Map(QuotaConfigs.IP_CONNECTION_RATE_OVERRIDE_CONFIG -> 
Some(updatedRate.toDouble)))
-    alterClientQuotas(admin, request).all.get()
+    alterClientQuotas(admin, request).all.get(JTestUtils.DEFAULT_MAX_WAIT_MS, 
TimeUnit.MILLISECONDS)

Review Comment:
   I was thinking altering of quotas is timing out, and before that's finished 
completely, connectionRateForIp has started to process without enough data, and 
times out probably ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to