mimaison commented on code in PR #16065:
URL: https://github.com/apache/kafka/pull/16065#discussion_r1626008733
##########
metadata/src/main/java/org/apache/kafka/metadata/FinalizedControllerFeatures.java:
##########
@@ -66,11 +66,9 @@ public boolean equals(Object o) {
@Override
public String toString() {
- StringBuilder bld = new StringBuilder();
- bld.append("{");
- bld.append("featureMap=").append(featureMap.toString());
- bld.append(", epoch=").append(epoch);
- bld.append("}");
- return bld.toString();
+ return "{" +
Review Comment:
In most other classes in this module `toString()` return a value with this
format `<CLASS_NAME>(<FIELDS>)` while this `toString()` method returns
`{<FIELDS>}`.
Since you're touching this method, let's make them consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
