lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1626479394
##########
core/src/test/scala/integration/kafka/api/PlaintextConsumerPollTest.scala:
##########
@@ -238,6 +238,20 @@ class PlaintextConsumerPollTest extends
AbstractConsumerTest {
runMultiConsumerSessionTimeoutTest(true)
}
+ // Ensure TestUtils polls with ZERO. This fails for the new consumer only.
Review Comment:
hey, I ran it locally again (I only change TestUtils ln 908 to poll with
Duration.ZERO as a quick shortcut):
- on trunk: test fails for new consumer only, passes for all other
combinations
- on this branch with latest changes: test passes for all combinations (yay!)
Not sure what made you have it failing for all combinations but to me this
PR seems to be fixing the issue, worth double checking to add the test if
possible, it's a very good validation of the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
