Goooler commented on code in PR #16176:
URL: https://github.com/apache/kafka/pull/16176#discussion_r1627519862
##########
build.gradle:
##########
@@ -47,9 +47,10 @@ plugins {
// Updating the shadow plugin version to 8.1.1 causes issue with signing and
publishing the shadowed
// artifacts - see https://github.com/johnrengelman/shadow/issues/901
id 'com.github.johnrengelman.shadow' version '8.1.0' apply false
- // the minimum required JRE of 6.14.0+ is 11
- //
refer:https://github.com/diffplug/spotless/tree/main/plugin-gradle#requirements
- id 'com.diffplug.spotless' version "6.13.0" apply false
+ // Spotless 6.13.0 has issue with Java 21 (see
https://github.com/diffplug/spotless/pull/1920), and Spotless 6.14.0+ requires
JRE 11
+ // We are going to drop JDK8 support. Hence, the spotless is upgrade to
newest version and be applied only if the build env is compatible with JDK 11.
+ // spotless 6.15.0+ has issue in runtime with JDK8 even through we define
it with `apply:false`. see https://github.com/diffplug/spotless/issues/2156 for
more details
+ id 'com.diffplug.spotless' version "6.14.0" apply false
Review Comment:
Sorry for the delay.
I think it would be great to throw exceptions if the current JRE is not Java
11 compatible. See
https://github.com/apache/kafka/pull/16176#discussion_r1627288939.
Either way, we can do that after dropping JDK8 as you described.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
