chia7712 commented on code in PR #16198: URL: https://github.com/apache/kafka/pull/16198#discussion_r1628187524
########## group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/GroupSpec.java: ########## @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.kafka.coordinator.group.assignor; +package org.apache.kafka.coordinator.group.api.assignor; import org.apache.kafka.common.Uuid; Review Comment: > You suggested to use MemberAssignment in your previous comment. MemberAssignment is already used in GroupAssignment returned by PartitionAssignor#assign. I am not sure if you meant to reuse the same MemberAssignment in both places. ummm, I guess I did not notice MemberAssignment is used by `GroupAssignment` before :_ Anyway, having a interface to replace `Map` struct is good way to me. Or we can keep current version if the tag "unstable" give the room to modify those public stuff :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
