mjsax commented on code in PR #16162:
URL: https://github.com/apache/kafka/pull/16162#discussion_r1628198975
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -351,7 +352,7 @@ public boolean isStartingRunningOrPartitionAssigned() {
private volatile KafkaFutureImpl<Map<String, KafkaFuture<Uuid>>>
producerInstanceIdFuture = new KafkaFutureImpl<>();
private volatile KafkaFutureImpl<Uuid> threadProducerInstanceIdFuture =
new KafkaFutureImpl<>();
- private final PunctuateRatioSlidingWindow punctuateRatioSlidingWindow =
new PunctuateRatioSlidingWindow(30000); // window size of 30 seconds
+ private final PunctuateRatioSlidingWindow punctuateRatioSlidingWindow =
new PunctuateRatioSlidingWindow(30000, new SystemTime()); // window size of 30
seconds
Review Comment:
We should not create a new `SystemTime` object here, but pass in the `time`
instance we already have at hand... Otherwise, we can still not mock it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
