philipnee commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1628589378
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##########
@@ -150,35 +200,44 @@ public void testStartupAndTearDown() throws
InterruptedException {
}
@Test
- public void testApplicationEvent() {
- ApplicationEvent e = new PollEvent(100);
- applicationEventsQueue.add(e);
+ public void testRequestManagersArePolledOnce() {
Review Comment:
i don't quite get the TransferFromManagersToClient part, perhaps you mean by
`
verify(networkClientDelegate).addAll(any(NetworkClientDelegate.PollResult.class));`
?
i agree that the test verifies a lot more calls than just verifying rms are
`PolledOnce`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
