jeffkbkim commented on code in PR #16198:
URL: https://github.com/apache/kafka/pull/16198#discussion_r1630030928
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/Assignment.java:
##########
@@ -29,7 +30,7 @@
/**
* An immutable assignment for a member.
*/
-public class Assignment {
+public class Assignment implements MemberAssignment {
Review Comment:
So, Assignment is different from MemberAssignmentImpl in that it will also
be used for client side assignors, possibly in the future, whereas
MemberAssignmentImpl is only used for server side assignors. is this correct?
I think it might be worth adding a short comment or perhaps merging it now
in a follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
