rreddy-22 commented on code in PR #16233:
URL: https://github.com/apache/kafka/pull/16233#discussion_r1630235368
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java:
##########
@@ -77,13 +77,13 @@ public GroupAssignment assign(
if (groupSpec.subscriptionType().equals(HOMOGENEOUS)) {
LOG.debug("Detected that all members are subscribed to the same
set of topics, invoking the "
+ "optimized assignment algorithm");
Review Comment:
nit: we might want to change the log statements as well?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java:
##########
@@ -77,13 +77,13 @@ public GroupAssignment assign(
if (groupSpec.subscriptionType().equals(HOMOGENEOUS)) {
LOG.debug("Detected that all members are subscribed to the same
set of topics, invoking the "
+ "optimized assignment algorithm");
- return new OptimizedUniformAssignmentBuilder(groupSpec,
subscribedTopicDescriber)
+ return new UniformHomogenousAssignmentBuilder(groupSpec,
subscribedTopicDescriber)
.build();
} else {
LOG.debug("Detected that the members are subscribed to different
sets of topics, invoking the "
+ "general assignment algorithm");
Review Comment:
nit: ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
