[
https://issues.apache.org/jira/browse/KAFKA-16638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852977#comment-17852977
]
Eric Lu commented on KAFKA-16638:
---------------------------------
[~omnia_h_ibrahim] I have written a KIP:
[https://cwiki.apache.org/confluence/display/KAFKA/KIP-1053%3A+Align+the+naming+convention+for+config+and+default+variables+in+*Config+classes]
I have received the comment that it might not be totally worth it to rename the
variable from the public interfaces only for alignment reasons. What do you
think? We can keep the alignment only at the configs that are not involved with
the public interface.
Cheers,
Eric
> Align the naming convention for config and default variables in *Config
> classes
> -------------------------------------------------------------------------------
>
> Key: KAFKA-16638
> URL: https://issues.apache.org/jira/browse/KAFKA-16638
> Project: Kafka
> Issue Type: Task
> Reporter: Omnia Ibrahim
> Priority: Trivial
>
> Some classes in the code is violating the naming naming convention for
> config, doc, and default variables which is:
> * `_CONFIG` suffix for defining the configuration
> * `_DEFAULT` suffix for default value
> * `_DOC` suffix for doc
> The following classes need to be updated
> * `CleanerConfig` and `RemoteLogManagerConfig` to use `_CONFIG` suffix
> instead of `_PROP`.
> * Others like `LogConfig` and `QuorumConfig` to use `_DEFAULT` suffix
> instead of `DEFAULT_` prefix .
> * same goes with `CommonClientConfigs`, `StreamsConfig` however these are
> public interfaces and will need a KIP to rename the default value variables
> and mark the old one as deprecated. This might need to be broken to different
> Jira.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
