showuon commented on code in PR #16232:
URL: https://github.com/apache/kafka/pull/16232#discussion_r1630923359
##########
server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java:
##########
@@ -310,12 +313,21 @@ void testOnCompletion() throws Exception {
}
private static ClientResponse
buildSuccessfulResponse(AssignReplicasToDirsRequestData request) {
+ return buildSuccessfulResponse(request, topicIdPartition ->
Errors.NONE);
+ }
+
+ private static ClientResponse
buildSuccessfulResponse(AssignReplicasToDirsRequestData request,
Review Comment:
nit: I don't think this is always a successful response any more. Maybe
rename to `buildResponse`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
