chia7712 commented on code in PR #16250:
URL: https://github.com/apache/kafka/pull/16250#discussion_r1632066886
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -3649,7 +3652,7 @@ public DeleteConsumerGroupOffsetsResult
deleteConsumerGroupOffsets(
@Override
public Map<MetricName, ? extends Metric> metrics() {
- return Collections.unmodifiableMap(this.metrics.metrics());
+ return new HashMap<>(this.metrics.metrics());
Review Comment:
We should keep it immutable, since other client components, such as consumer
and producer, return immutable collection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
