chia7712 commented on code in PR #16260:
URL: https://github.com/apache/kafka/pull/16260#discussion_r1632550895


##########
build.gradle:
##########
@@ -2178,6 +2177,7 @@ project(':tools') {
     implementation libs.jacksonDataformatCsv
     implementation libs.jacksonJDK8Datatypes
     implementation libs.slf4jApi
+    implementation libs.slf4jlog4j

Review Comment:
   ya, we do need that binding jar when running broker/controller. But stream 
examples module has declared that:
   
   https://github.com/apache/kafka/blob/trunk/build.gradle#L2613
   
   I check the distribution, and both `reload4j` and `slf4j-reload4j` are 
existent.
   
   ![螢幕快照 2024-06-10 
12-08-23](https://github.com/apache/kafka/assets/6234750/d8bdcd4f-5344-44db-b72e-4cc7710ae2cf)
   
   Also, I run the command you described but I don't see "Failed to load class 
.. "
   
   ![螢幕快照 2024-06-10 
12-07-27](https://github.com/apache/kafka/assets/6234750/cffda7d9-9c94-48ec-a7e4-ef80746f61d7)
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to