adixitconfluent commented on code in PR #16268:
URL: https://github.com/apache/kafka/pull/16268#discussion_r1633612948
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -1455,6 +1487,30 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
s"${GroupCoordinatorConfig.CONSUMER_GROUP_SESSION_TIMEOUT_MS_CONFIG}
must be less than or equals " +
s"to
${GroupCoordinatorConfig.CONSUMER_GROUP_MAX_SESSION_TIMEOUT_MS_CONFIG}")
+ require(shareGroupMaxHeartbeatIntervalMs >=
shareGroupMinHeartbeatIntervalMs,
+ s"${ShareGroupConfigs.SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG} must
be greater than or equals " +
+ s"to
${ShareGroupConfigs.SHARE_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG}")
+ require(shareGroupHeartbeatIntervalMs >= shareGroupMinHeartbeatIntervalMs,
+ s"${ShareGroupConfigs.SHARE_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG} must be
greater than or equals " +
+ s"to
${ShareGroupConfigs.SHARE_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG}")
+ require(shareGroupHeartbeatIntervalMs <= shareGroupMaxHeartbeatIntervalMs,
+ s"${ShareGroupConfigs.SHARE_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG} must be
less than or equals " +
+ s"to
${ShareGroupConfigs.SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_CONFIG}")
+
+ require(shareGroupMaxSessionTimeoutMs >= shareGroupMinSessionTimeoutMs,
+ s"${ShareGroupConfigs.SHARE_GROUP_MAX_SESSION_TIMEOUT_MS_CONFIG} must be
greater than or equals " +
+ s"to ${ShareGroupConfigs.SHARE_GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG}")
+ require(shareGroupSessionTimeoutMs >= shareGroupMinSessionTimeoutMs,
+ s"${ShareGroupConfigs.SHARE_GROUP_SESSION_TIMEOUT_MS_CONFIG} must be
greater than or equals " +
+ s"to ${ShareGroupConfigs.SHARE_GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG}")
+ require(shareGroupSessionTimeoutMs <= shareGroupMaxSessionTimeoutMs,
+ s"${ShareGroupConfigs.SHARE_GROUP_SESSION_TIMEOUT_MS_CONFIG} must be
less than or equals " +
+ s"to ${ShareGroupConfigs.SHARE_GROUP_MAX_SESSION_TIMEOUT_MS_CONFIG}")
+
+ require(shareGroupMaxRecordLockDurationMs >=
shareGroupRecordLockDurationMs,
Review Comment:
sure, I'll add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
