lianetm commented on code in PR #16291:
URL: https://github.com/apache/kafka/pull/16291#discussion_r1635458303
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -1278,5 +1275,12 @@ static class MemberInfo {
this.memberId = Optional.empty();
this.memberEpoch = Optional.empty();
}
+
+ @Override
+ public String toString() {
+ return "MemberInfo{" + "memberId=" + memberId.orElse("undefined") +
+ ", memberEpoch=" + (memberEpoch.isPresent() ? memberEpoch
: "undefined") + "}";
Review Comment:
I would say we need to check if present. There could be no epoch/id when
committing/fetching (if we haven't joined a group or left it. In those cases we
would have empty here, so that no epoch/id is included in the
OffsetFetch/OffsetCommit request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
