ableegoldman commented on code in PR #16294:
URL: https://github.com/apache/kafka/pull/16294#discussion_r1635794717
##########
streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java:
##########
@@ -55,7 +56,103 @@ public final class TaskAssignmentUtils {
private TaskAssignmentUtils() {}
/**
- * Return an {@code AssignmentError} for a task assignment created for an
application.
+ * A simple config container for necessary parameters and optional
overrides to apply when
+ * running the active or standby task rack-aware optimizations.
+ */
+ public static class RackAwareOptimizationParams {
Review Comment:
nit: make this final
##########
streams/src/main/java/org/apache/kafka/streams/processor/assignment/TaskAssignmentUtils.java:
##########
@@ -55,7 +56,103 @@ public final class TaskAssignmentUtils {
private TaskAssignmentUtils() {}
/**
- * Return an {@code AssignmentError} for a task assignment created for an
application.
+ * A simple config container for necessary parameters and optional
overrides to apply when
+ * running the active or standby task rack-aware optimizations.
+ */
+ public static class RackAwareOptimizationParams {
+ private final ApplicationState applicationState;
+ private final Optional<Integer> trafficCostOverride;
+ private final Optional<Integer> nonOverlapCostOverride;
+ private final Optional<SortedSet<TaskId>> tasksToOptimize;
+
+ private RackAwareOptimizationParams(final ApplicationState
applicationState,
+ final Optional<Integer>
trafficCostOverride,
+ final Optional<Integer>
nonOverlapCostOverride,
+ final Optional<SortedSet<TaskId>>
tasksToOptimize) {
Review Comment:
nit: indentation is off by one space I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
