showuon commented on code in PR #16221:
URL: https://github.com/apache/kafka/pull/16221#discussion_r1635814686
##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -1181,7 +1181,7 @@ object TestUtils extends Logging {
transactionVerificationEnabled: Boolean = false,
log: Option[UnifiedLog] = None,
remoteStorageSystemEnable: Boolean = false,
- initialTaskDelayMs: Long =
ServerLogConfigs.LOG_INITIAL_TASK_DELAY_MS_DEFAULT): LogManager = {
+ initialTaskDelayMs: Long =
ServerLogConfigs.LOG_INITIAL_TASK_DELAY_MS_DEFAULT_INTEGRATION_TEST):
LogManager = {
Review Comment:
Yes, `createBrokerConfigs` is a place to override some configs for testing,
like we set `props.put(ServerLogConfigs.LOG_DELETE_DELAY_MS_CONFIG, "1000")`,
so that we can quickly delete a log file to speed up the test. Similar things
like
```
// Reduce number of threads per broker
props.put(ServerConfigs.NUM_NETWORK_THREADS_CONFIG, "2")
props.put(ServerConfigs.BACKGROUND_THREADS_CONFIG, "2")
```
As the comment said, we want to reduce the number of threads per broker, to
speed up the tests.
That's why we should add a smaller initialTaskDelay here to speed up tests.
Does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
