abhijeetk88 commented on code in PR #16078:
URL: https://github.com/apache/kafka/pull/16078#discussion_r1635838230
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -1165,43 +1165,66 @@ class DynamicRemoteLogConfig(server: KafkaBroker)
extends BrokerReconfigurable w
override def validateReconfiguration(newConfig: KafkaConfig): Unit = {
newConfig.values.forEach { (k, v) =>
- if (reconfigurableConfigs.contains(k)) {
- if
(k.equals(RemoteLogManagerConfig.REMOTE_LOG_INDEX_FILE_CACHE_TOTAL_SIZE_BYTES_PROP))
{
- val newValue = v.asInstanceOf[Long]
- val oldValue = getValue(server.config, k)
- if (newValue != oldValue && newValue <= 0) {
- val errorMsg = s"Dynamic remote log manager config update
validation failed for $k=$v"
- throw new ConfigException(s"$errorMsg, value should be at least 1")
- }
+ if
(k.equals(RemoteLogManagerConfig.REMOTE_LOG_INDEX_FILE_CACHE_TOTAL_SIZE_BYTES_PROP)
||
Review Comment:
Not completely sure if `k` can be null, but I changed it since it provides
safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
