abhijeetk88 commented on code in PR #16087:
URL: https://github.com/apache/kafka/pull/16087#discussion_r1635882465
##########
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##########
@@ -77,16 +78,17 @@ public void updateQuota(Quota newQuota) {
}
}
- public boolean isQuotaExceeded() {
+ public QuotaCheckResult checkQuota() {
Sensor sensorInstance = sensor();
try {
sensorInstance.checkQuotas();
} catch (QuotaViolationException qve) {
LOGGER.debug("Quota violated for sensor ({}), metric: ({}),
metric-value: ({}), bound: ({})",
sensorInstance.name(), qve.metric().metricName(), qve.value(),
qve.bound());
- return true;
+ long throttleTimeMs = QuotaUtils.throttleTime(qve,
time.milliseconds());
+ return new QuotaCheckResult(true, throttleTimeMs);
Review Comment:
Makes sense. Made the changes as requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
