chia7712 commented on PR #16302: URL: https://github.com/apache/kafka/pull/16302#issuecomment-2163061840
> In https://github.com/apache/kafka/pull/16133 I was trying to break this cyclic dependency and also remove the KafkaConfig dependency of one of these classes but they are really badly entangled. I think your change is the best we can do for now.In https://github.com/apache/kafka/pull/16133 I was trying to break this cyclic dependency and also remove the KafkaConfig dependency of one of these classes but they are really badly entangled. I think your change is the best we can do for now. I check the commit history before creating KAFKA-16938, and then ... the reviewer list shows my name :smiling_face_with_tear: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
