chia7712 commented on code in PR #16304:
URL: https://github.com/apache/kafka/pull/16304#discussion_r1636807325
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -207,8 +207,7 @@ private void reapExpiredApplicationEvents(long
currentTimeMs) {
*/
// Visible for testing
static void runAtClose(final Collection<Optional<? extends
RequestManager>> requestManagers,
- final NetworkClientDelegate networkClientDelegate,
- final Timer timer) {
Review Comment:
thanks for sharing, and I agree that the usage of `pollOnClose` you
described, so +1 to remove `timer` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
