AyoubOm commented on code in PR #16218:
URL: https://github.com/apache/kafka/pull/16218#discussion_r1639815011
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKeySchema.java:
##########
@@ -94,7 +94,7 @@ public CombinedKey<KO, K> fromBytes(final Bytes data) {
return new CombinedKey<>(foreignKey, primaryKey);
}
- Bytes prefixBytes(final KO key) {
+ public Bytes prefixBytes(final KO key) {
Review Comment:
same here
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKeySchema.java:
##########
@@ -60,7 +60,7 @@ public void init(final ProcessorContext<?, ?> context) {
foreignKeyDeserializer = foreignKeyDeserializer == null ?
(Deserializer<KO>) context.keySerde().deserializer() : foreignKeyDeserializer;
}
- Bytes toBytes(final KO foreignKey, final K primaryKey) {
+ public Bytes toBytes(final KO foreignKey, final K primaryKey) {
Review Comment:
I guess we don't need to change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
