jolshan commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1639981075
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##########
@@ -618,7 +624,7 @@ class TransactionStateManager(brokerId: Int,
// generate the message for this transaction metadata
val keyBytes = TransactionLog.keyToBytes(transactionalId)
- val valueBytes = TransactionLog.valueToBytes(newMetadata)
+ val valueBytes = TransactionLog.valueToBytes(newMetadata,
usesFlexibleRecords())
Review Comment:
Functionally there is no difference now, so a test didn't come to my mind
easily. I guess the best thing is to just look at the version of the record
generated. I can add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
