chia7712 commented on code in PR #16350:
URL: https://github.com/apache/kafka/pull/16350#discussion_r1641453002
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##########
@@ -147,7 +147,7 @@
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.withSettings;
-@RunWith(MockitoJUnitRunner.StrictStubs.class)
+@ExtendWith(MockitoExtension .class)
Review Comment:
please add `@MockitoSettings(strictness = Strictness.STRICT_STUBS)`
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##########
@@ -147,7 +147,7 @@
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.withSettings;
-@RunWith(MockitoJUnitRunner.StrictStubs.class)
+@ExtendWith(MockitoExtension .class)
Review Comment:
also, please remove redundant "space"
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##########
@@ -110,7 +111,8 @@
import static org.mockito.Mockito.when;
import static org.mockito.Mockito.withSettings;
-@RunWith(MockitoJUnitRunner.StrictStubs.class)
+@ExtendWith(MockitoExtension.class)
+@MockitoSettings(strictness = Strictness.STRICT_STUBS)
@SuppressWarnings("unchecked")
public class StandaloneHerderTest {
Review Comment:
Could we reuse the existent code as much as possible? please take a look
this example:
[StandaloneHerderTest.txt](https://github.com/user-attachments/files/15855186/StandaloneHerderTest.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
