chia7712 commented on PR #16353: URL: https://github.com/apache/kafka/pull/16353#issuecomment-2172396287
> Update RemoteLogManagerConfig with the respective dynamic configs when a broker is initialized. In this case, the respective configs in RemoteLogManagerConfig should get updated and there won't be any dangling old config references. there was a discussion about "can we see the (latest) dynamic configs when a broker is initialized" (https://github.com/apache/kafka/pull/16353#discussion_r1641654171). In kraft, we create `remoteLogManager`[0] before updating dynamic configs [1]. Hence, it seems it is possible that `remoteLogManager` still see the static configs. This behavior is different to zk mode. Those remoteLogManager configs [3] can be updated later when publishing metadata (latest configs), so that is possibly be fine (?). Fixing the startup order seems be a big issue, and maybe it is hard to guarantee "all" components can see latest configs in kraft. [0] https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/BrokerServer.scala#L208 [1] https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/BrokerServer.scala#L499 [2] https://github.com/apache/kafka/blob/4a37c2e18f4658123557fc48957a310d53d31bac/core/src/main/scala/kafka/server/DynamicBrokerConfig.scala#L1178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
