lianetm commented on code in PR #16345:
URL: https://github.com/apache/kafka/pull/16345#discussion_r1643334957
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -680,6 +694,7 @@ public NetworkClientDelegate.UnsentRequest
toUnsentRequest() {
}
if (memberInfo.memberEpoch.isPresent()) {
data =
data.setGenerationIdOrMemberEpoch(memberInfo.memberEpoch.get());
+ lastEpochSentOnCommit =
Optional.of(memberInfo.memberEpoch.get());
Review Comment:
Both done, great catch the 2nd one! I added a test to make sure we got it
all right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
