[
https://issues.apache.org/jira/browse/KAFKA-16823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17856641#comment-17856641
]
Chia-Ping Tsai commented on KAFKA-16823:
----------------------------------------
The following comment is copy from PR:
{quote}
It would be nice to review all tests before separating them. Maybe we can do a
bit rewrite to make them works with both consumes.
{quote}
I had filed KAFKA-16957 to address a part of it, and I will dig in other tests
later.
> Extract LegacyConsumer-specific unit tests from generic KafkaConsumerTest
> --------------------------------------------------------------------------
>
> Key: KAFKA-16823
> URL: https://issues.apache.org/jira/browse/KAFKA-16823
> Project: Kafka
> Issue Type: Task
> Components: clients, consumer
> Reporter: Lianet Magrans
> Assignee: PoAn Yang
> Priority: Major
> Labels: kip-848-client-support
>
> Currently the KafkaConsumerTest file contains unit tests that apply to both
> consumer implementations, but also tests that apply to the legacy consumer
> only. We should consider splitting the tests that apply to the legacy only
> into their own LegacyConsumerTest file (aligning with the existing
> AsyncKafkaConsumerTest). End result would be:
> KafkaConsumerTest -> unit tests that apply to both consumers.
> LegacyKafkaConsumerTest -> unit tests that apply only to the
> LegacyKafkaConsumer, either because of the logic they test, or the way they
> are written (file to be created with this task)
> AsyncKafkaConsumerTest -> unit tests that apply only to the
> AsyncKafkaConsumer (this file already exist)
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
