loicgreffier commented on code in PR #16093:
URL: https://github.com/apache/kafka/pull/16093#discussion_r1649445442
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StampedRecord.java:
##########
@@ -49,6 +51,21 @@ public Headers headers() {
return value.headers();
}
+ public ConsumerRecord<byte[], byte[]> rawRecord() {
+ return rawRecord;
+ }
+
+ @Override
+ public boolean equals(final Object other) {
+ // Do not include rawRecord in the comparison
+ return super.equals(other);
+ }
+
+ @Override
+ public int hashCode() {
+ return super.hashCode();
+ }
+
Review Comment:
@cadonna Correct, it is the exact same behaviour.
I had a SpotBugs warning on this one to explicitly override and call super
methods (e.g., like here:
https://github.com/apache/kafka/blob/trunk/server/src/main/java/org/apache/kafka/security/authorizer/AclEntry.java#L201).
Override can be removed and warning can be ignored if it is more convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
