apoorvmittal10 commented on code in PR #16430:
URL: https://github.com/apache/kafka/pull/16430#discussion_r1650900179
##########
checkstyle/suppressions.xml:
##########
@@ -39,6 +39,7 @@
<suppress
checks="(NPathComplexity|ClassFanOutComplexity|CyclomaticComplexity|ClassDataAbstractionCoupling|FinalLocalVariable|LocalVariableName|MemberName|ParameterName|MethodLength|JavaNCSS|AvoidStarImport)"
files="core[\\/]src[\\/](generated|generated-test)[\\/].+.java$"/>
<suppress checks="NPathComplexity"
files="(ClusterTestExtensions|KafkaApisBuilder|SharePartition).java"/>
+ <suppress checks="CyclomaticComplexity" files="(SharePartition).java"/>
Review Comment:
Can we reduce the cyclomatic complexity? I have refactored acquire and
acknowledge methods to sub methods to decrease the complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
