OmniaGM commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2197745489
> Also did we decide: > > > ReplicaManager still look for HostedPartition using TopicPartition and doesn't check topic id. This is an [OPEN QUESTION] if we should address this in this pr or wait for [KAFKA-16212](https://issues.apache.org/jira/browse/KAFKA-16212) as this will update ReplicaManager::getPartition to use TopicIdParittion once we update the cache. Other option is that we compare provided topicId with Partition topic id and return UNKNOW_TOPIC_ID or UNKNOW_TOPIC_PARTITION if we can't find partition with matched topic id. Personally I am leaning toward keep TopicPartition for now until we pickup https://issues.apache.org/jira/browse/KAFKA-16212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
