jsancio commented on code in PR #16454:
URL: https://github.com/apache/kafka/pull/16454#discussion_r1663336934
##########
raft/src/test/java/org/apache/kafka/raft/CandidateStateTest.java:
##########
@@ -58,193 +60,229 @@ private CandidateState newCandidateState(VoterSet voters)
{
);
}
- @Test
- public void testSingleNodeQuorum() {
- CandidateState state =
newCandidateState(voterSetWithLocal(IntStream.empty()));
+ @ParameterizedTest
+ @ValueSource(booleans = { true, false })
Review Comment:
Looks like Kafka's checkstyle accepts both (`{ true, false }` and `{true,
false}`). If we want to change this, do you mind if we do this in another PR? I
use this style in a lot of places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
